This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix a bug when using fp16 training & gradient clipping #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YKX-A can you run |
epwalsh
reviewed
Oct 1, 2021
| # 1. We have to unscale the gradient before clipping | ||
| if self._scaler is not None: | ||
| optimizer_state = self._scaler._per_optimizer_states[id(self.optimizer)] | ||
| # 2. The `unscale_` should't be performed more than once per optimizer per step call, |
There was a problem hiding this comment.
Suggested change
| # 2. The `unscale_` should't be performed more than once per optimizer per step call, | |
| # 2. The `unscale_` shouldn't be performed more than once per optimizer per step call, |
There was a problem hiding this comment.
Oh, that's my ignorance 😰. Is it correct now?
epwalsh
approved these changes
Oct 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
(@epwalsh, Come here to see if it's ok.)
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.