Alliterations #102
Merged
Alliterations #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented by both `Petnames` and `Alliterations`.
Also, impls of `Alliterations.retain` and `Alliterations.cardinality`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts a
Generatortrait out ofPetnames, then introduces a newAlliterationstype that implements it too. It's possible to create anAlliterationsdirectly from aPetnamesand then use it to generate names just the same, except that all words in generated names will start with the same letter. The difference to before is that now, when generating multiple names, each name does not need to start with the same letter as the previous name.Fixes #60.