Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domEvent should support key #7

Closed
allevo opened this issue May 18, 2024 · 0 comments · Fixed by #19
Closed

domEvent should support key #7

allevo opened this issue May 18, 2024 · 0 comments · Fixed by #19
Labels
framework Framework core

Comments

@allevo
Copy link
Owner

allevo commented May 18, 2024

Currently, SeqFlow forces us to use { el: button } to attach an event handler to a HTMLElement. While this is technically correct, it is not developer-friendly.

SeqFlow already uses key for other purposes; we can use { key: 'incrementButton' } to specify the element you want to attach to the handler.

NB: it seems easy to implement, but it could be tricky when you use the domEvent method after replaceChild on the same element. What should happen in that case?

@allevo allevo added the framework Framework core label May 18, 2024
allevo added a commit that referenced this issue Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Framework core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant