This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Rework into a Docker container action #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than handling input validation inside the composite action with the difficulty of dealing with an unknown set of environment variables, rework it into a Docker container action. The entrypoint.sh in Bash takes care of input validation and execution behavior.
The workdir is set to /github/workspace so everything should just work out of the box.
Some errors were introduced by rewriting rather than doing a copy-paste.
Adopt the new functionality from the Docker container Action in the example workflow.
nicorikken
force-pushed
the
feature/docker-step
branch
from
7d85adb to
266b17b
Compare
nicorikken
force-pushed
the
feature/docker-step
branch
from
a6d154d to
8270cb2
Compare
The NODE_CONFIG_USERCONFIG was falsely used and this is corrected to the NPM_CONFIG_USERCONFIG variable.
|
Having done some more trials and thinking, I think this is the right approach, so I'll merge it and continue from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than handling input validation inside the composite action with the
difficulty of dealing with an unknown set of environment variables, rework it
into a Docker container action. The entrypoint.sh in Bash takes care of input
validation and execution behavior.