-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2.45 bugfix sources #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(turned out version numbering of the ERA5 Single Levels model was set as a numeric value, rather than the required string format)
FIXED: - Harmonie Arome filtering should now work as intended - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though) - OpenAPI Specification properly is now updated. - Several code smells have been removed / erased. CHANGES: - Core API functionality has been upgraded - Logging handler has been replaced with loguru - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents.
rflinnenbank
added
bug
Something isn't working as it should and needs to be fixed!
high priority
This issue is given a high priority
investigation
This issue does not deal with fixing an issue, but currently is about finding out the cause only.
labels
Oct 31, 2023
(turned out version numbering of the ERA5 Single Levels model was set as a numeric value, rather than the required string format) Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
FIXED: - Harmonie Arome filtering should now work as intended - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though) - OpenAPI Specification properly is now updated. - Several code smells have been removed / erased. CHANGES: - Core API functionality has been upgraded - Logging handler has been replaced with loguru - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents. Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
…o feature/2.45-bugfix-sources
SonarCloud Quality Gate failed. 0 Bugs 25.9% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
rflinnenbank
added a commit
that referenced
this pull request
Nov 2, 2023
* Feature/2.45 bugfix sources (#114) * [2023-10-31 16:18] Multiple fixes and improvements FIXED: - Harmonie Arome filtering should now work as intended - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though) - OpenAPI Specification properly is now updated. - Several code smells have been removed / erased. CHANGES: - Core API functionality has been upgraded - Logging handler has been replaced with loguru - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents. Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com> * [2023-11-01 08:33] Server setting adjustments Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com> * [2023-11-01 08:53] Docker image update * [2023-11-01 09:02] Docker image update #2 * [2023-11-01 09:04] Relative import fix * [2023-11-01 09:16] Docker Image update Fixes new application location * Delete openapi.json Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com> --------- Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working as it should and needs to be fixed!
high priority
This issue is given a high priority
investigation
This issue does not deal with fixing an issue, but currently is about finding out the cause only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.