Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2.45 bugfix sources #114

Merged
merged 11 commits into from
Nov 1, 2023
Merged

Conversation

rflinnenbank
Copy link
Collaborator

No description provided.

(turned out version numbering of the ERA5 Single Levels model was set as a numeric value, rather than the required string format)
FIXED:
 - Harmonie Arome filtering should now work as intended
 - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though)
 - OpenAPI Specification properly is now updated.
 - Several code smells have been removed / erased.

CHANGES:
 - Core API functionality has been upgraded
 - Logging handler has been replaced with loguru
 - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents.
@rflinnenbank rflinnenbank added bug Something isn't working as it should and needs to be fixed! high priority This issue is given a high priority investigation This issue does not deal with fixing an issue, but currently is about finding out the cause only. labels Oct 31, 2023
@rflinnenbank rflinnenbank self-assigned this Oct 31, 2023
(turned out version numbering of the ERA5 Single Levels model was set as a numeric value, rather than the required string format)

Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
FIXED:
 - Harmonie Arome filtering should now work as intended
 - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though)
 - OpenAPI Specification properly is now updated.
 - Several code smells have been removed / erased.

CHANGES:
 - Core API functionality has been upgraded
 - Logging handler has been replaced with loguru
 - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents.
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

25.9% 25.9% Coverage
0.6% 0.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rflinnenbank rflinnenbank merged commit 6af50c9 into release-2.45 Nov 1, 2023
5 of 6 checks passed
@rflinnenbank rflinnenbank deleted the feature/2.45-bugfix-sources branch November 1, 2023 07:43
rflinnenbank added a commit that referenced this pull request Nov 2, 2023
* Feature/2.45 bugfix sources (#114)

* [2023-10-31 16:18] Multiple fixes and improvements

FIXED:
 - Harmonie Arome filtering should now work as intended
 - Harmonie Arome now better handles duplicate factor values. (will still need to look into what is going on with those duplicates though)
 - OpenAPI Specification properly is now updated.
 - Several code smells have been removed / erased.

CHANGES:
 - Core API functionality has been upgraded
 - Logging handler has been replaced with loguru
 - Due to issues with the OpenAPI spec's validity, optional WeatherModel fields have been replaced with non-optional equivalents.
Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>

* [2023-11-01 08:33] Server setting adjustments

Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>

* [2023-11-01 08:53] Docker image update

* [2023-11-01 09:02] Docker image update #2

* [2023-11-01 09:04] Relative import fix

* [2023-11-01 09:16] Docker Image update

Fixes new application location

* Delete openapi.json

Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>

---------

Signed-off-by: Raoul Linnenbank <58594297+rflinnenbank@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as it should and needs to be fixed! high priority This issue is given a high priority investigation This issue does not deal with fixing an issue, but currently is about finding out the cause only.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant