Update Fun module #421
Merged
Update Fun module #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-line
reviewed
Jun 21, 2017
modules/fun/fun.cpp
Outdated
| auto index = TypeConversion.edict_to_id(pEntity); | ||
|
|
||
| if (Players[index].HasSilentFootsteps()) | ||
| { | ||
| pEntity->v.flTimeStepSound = 999; |
There was a problem hiding this comment.
I think it's more correct to hook PM_PlayStepSound
There was a problem hiding this comment.
Yes. I could be wrong, but so far I remember, the best method to silent totally a player's footsteps is to stop PM_PlayStepSound execution (a good method which doesn't require gamedata is to hook PM_Move and set runfuncs to 0, I believe), then to stop the sound on your client, you need to send an updated SVC_NEWMOVEVARS message (this requires to hook SV_WriteMovevarsToClient as well).
Is it worth? I'm not sure. It could be if we had a native which can exploit this method to set options that we can't usually have per player (airaccelerate, edgefriction, roll, sky?, etc.).
Arkshine
force-pushed
the
update/fun-module
branch
from
844a56e to
5e1b0e0
Compare
Reason: as it is it breaks plugins hooking TraceLine because of the original game call is being superceded and other modules can't catch it. It looks like it's this way from the very start fun module has been introduced 13 years ago before. Fakemeta module comes a little later.
Arkshine
force-pushed
the
update/fun-module
branch
from
5e1b0e0 to
f429be6
Compare
|
Alright, rebase + cleanup + test done. |
This was referenced Sep 1, 2018
OciXCrom
pushed a commit
to OciXCrom/amxmodx
that referenced
this pull request
Sep 10, 2018
* Fun: Replace ENTINDEX with TypeConversion for consistency * Fun: Add a class wrapping player's data * Fun: Make TraceLine a post forward Reason: as it is it breaks plugins hooking TraceLine because of the original game call is being superceded and other modules can't catch it. It looks like it's this way from the very start fun module has been introduced 13 years ago before. Fakemeta module comes a little later. * Fun: Clean up code * Fun: Toggle PlayerPreThink forward on demand * Fun: Toggle TraceLine forward on demand * Fun: Add HITZONE* constants for use with set/get_user_hitzone() * Fun: Refactor a litte the player class * Fun: Clean up a little more * Fun: Fix typo in set_user_hitzones from previous commit
Closed
PartialCloning
added a commit
to PartialCloning/amxmodx
that referenced
this pull request
Jan 20, 2019
alliedmodders#554 (Revert "Fun: Make TraceLine a post forward") did not fully revert back TraceLine. RETURN_META(MRES_HANDLED); was added by alliedmodders#421 (Update Fun module) but still remains there.
Arkshine
pushed a commit
that referenced
this pull request
Jan 24, 2019
Arkshine
pushed a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a code clean up following with some welcomed changes:
PlayerPreThink(used withget/set_user_footsteps) andTraceLine(used withget/set_user_hitzones)forwards on-demand (in others words, those forwards won't be hooked if no plugins are using such natives or if no players are actually set by them)HITZONE_*constants forget/set_user_hitzones.TraceLinea post forward. Reason: as it is it breaks plugins hookingTraceLinebecause of the original game call is being superceded and other modules can't catch it. It looks like it's this way from the very start fun module has been introduced 13 years ago. Fakemeta module comes a little later. Change should be safe 1) it's unlikely having both plugins, one usingset_user_hitzonesand another hookingTraceLineas the latter would not work properly 2) This native is rarely used.To do: