Add constants for max IP and SteamID length

[OciXCrom]

I'm just not sure if the max SteamID length is 34. I wasn't able to find the best answer.

[WPMGPRoSToTeMa]

It should be _SIZE, because _LENGTH is _SIZE - 1 for C strings, but anyway MAX_NAME_LENGTH is already here.

[OciXCrom]

@WPMGPRoSToTeMa I know, but I made it _LENGTH for consistency with MAX_NAME_LENGTH.

[Arkshine]

Looks good for me. Do you see something else, @WPMGPRoSToTeMa?

[WPMGPRoSToTeMa]

@Arkshine constants for resource path, userinfo, motd, menu length?

[Arkshine]

Resource path -> 64
Motd -> don't remember, ~1280?

What do you mean by 'userinfo', and 'menu length'?

[WPMGPRoSToTeMa]

@Arkshine motd -> 1536.

What do you mean by 'userinfo'

get_user_info, copy_infokey_buffer, etc. natives, setinfo command -> 256.

and 'menu length'?

Menu contents length -> 512.

[Arkshine]

Sounds good.

[SergeyShorokhov]

Don't forget PLATFORM_MAX_PATH

[Arkshine]

It's defined to 260 because this would be the max path length in windows.
But the resource files you precache through the engine and sent to the client is limited to 64 characters.

[SergeyShorokhov]

also don't forget #define MAX_QUERY_LENGTH 1472. Why 1472? - idk

[OciXCrom]

I added these:

#define MAX_RESOURCE_PATH_LENGTH 64
#define MAX_MOTD_LENGTH 1536
#define MAX_USER_INFO_LENGTH 256
#define MAX_MENU_LENGTH 512
#define MAX_QUERY_LENGTH 1472

[Arkshine]

also don't forget #define MAX_QUERY_LENGTH 1472. Why 1472? - idk

What kind of query you're talking about? Where did you see this constant?

[WPMGPRoSToTeMa]

@Arkshine I think he's talking about SQL queries.

[Arkshine]

Why 1472? The limit would be the limit defined by some MySQL options, like maybe max_allowed_packet. But since we are talking about AMXX, it comes down to the AMXX buffer and even before that the compiler. The compiler input line max length is 4095, and it seems MySQL module uses internally a buffer of 4096 to save the query. If anything it should be 4096, but I don't know if it makes sense to define such a large max length.

[rsKliPPy]

Nah, at most the MySQL module should log a warning that the query string has exceeded maximum size. A constant is unnecessary.

[IgnacioFDM]

Compiler input line length is pretty unrelated to query length, since usually (long queries) are built (as in, not just a string literal, but lots of stuff inserted into the string).

I think the 4096 current limit is pretty low btw, it's common to have single INSERT queries that you build with multiple values, instead of thousands of single value queries.

These long INSERT queries are many kilobytes or megabytes long if you don't split them so as to fit with the current limit.

You probably can't, or shouldn't at least, allocate megabytes in the stack of an AMXX plugin , but 16K is probably within reason.

I'm currently using this constant, so it might be useful to add. However I think the name should be different, like SQL_MAX_QUERY_LENGTH and be included in sqlx.inc

[rsKliPPy]

The solution is to introduce transactions for such queries if they are the main problem.

[OciXCrom]

What about the maximum hostname length? Is it 64?

[Arkshine]

Let's go with that for now. If we need others constants, feel free to open a new PR.

[WPMGPRoSToTeMa]

@OciXCrom

What about the maximum hostname length? Is it 64?

It is not the same in different games.
https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/cl_dll/global_consts.h#L27
https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/dmc/cl_dll/vgui_viewport.h#L72

[WPMGPRoSToTeMa]

Oh, sorry, looks like it is not the same for different games too:
https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/dmc/cl_dll/hud.h#L56
https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/cl_dll/hud.h#L61

[Mistrick]

but we don't know current code base.
hl now support color menus. what else has changed in current builds?

[WPMGPRoSToTeMa]

@Mistrick that repository contains colored menu support.