Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to hlsdk_const and cstrike_const #573

Merged
merged 3 commits into from
Sep 23, 2018
Merged

Additions to hlsdk_const and cstrike_const #573

merged 3 commits into from
Sep 23, 2018

Conversation

PartialCloning
Copy link
Contributor

Added values to cstrike_const and hlsdk_const using regamedll_cs and reapi as reference.

Added values to hlsdk_const using regamedll_cs and reapi as reference.
@Arkshine
Copy link
Member

Looks good.

Not sure if we should prefix CS_ for those specific CS constants as well.

@dystopm
Copy link

dystopm commented Sep 19, 2018

I've checked this, values are ok :)

@Arkshine
Copy link
Member

Alright, let's go with that.

@Arkshine Arkshine merged commit c3225af into alliedmodders:master Sep 23, 2018
Arkshine pushed a commit that referenced this pull request Sep 28, 2018
* Additions to hlsdk_const

Added values to hlsdk_const using regamedll_cs and reapi as reference.

* Update cstrike_const.inc

* Prefix constants with CS_ to avoid name collision and for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants