Update parson and fix json_object_set_value #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoromaniello
changed the title
|
JSON original repo has been receiving several commits since its release as a AMXX Module but hasn't received any update since then, this worth a watch i guess. |
|
We can't include submodules to third-party repos since it exposes various risks. Two options: we either fork it into the AlliedModders team github, and keep the two in sync - or we copy and paste the files in. Since we already did the copy and paste here, and it's quite a small repository, that would be the easier route. |
|
I think we should just fork it (not sure why it was not like that before?) considering that in the long term it should be more easy to maintain and start working from there. |
Arkshine
pushed a commit
that referenced
this pull request
Sep 17, 2021
* Remove parson folder * add submodule parson * FIX amxx_json_object_set_value generate a crash if invalid value is passed * restore parson folder status
Closed
Th3-822
added a commit
to Th3-822/amxmodx
that referenced
this pull request
Nov 26, 2021
Regression from alliedmodders#983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json module needs to update the parson dependency, the repository of parson have commits for memory leaks and more.
I made a git submodule to the repository to make it more easy to update.
EDIT: Also fixed json_object_set_value generate a crash if invalid value is passed
Image related to the crash of json_object_set_value
EDIT 2: it's required another pull to 1.9-dev ? is the correct branch master to make a pull ?