Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libmaxminddb and MySQL 5.7 #2192

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Update libmaxminddb and MySQL 5.7 #2192

merged 3 commits into from
Nov 2, 2024

Conversation

accelerator74
Copy link
Contributor

@accelerator74 accelerator74 commented Jul 15, 2024 •
edited
Loading

Suggestion to use MySQL 5.7 as default for checkout-deps.sh on Linux. Will be useful after merging this PR: #2189

In addition, an update to the libmaxminddb library.

@accelerator74 accelerator74 changed the title Update libmaxminddb and MySQL 5.7 (linux checkout) Update libmaxminddb and MySQL 5.7 Jul 15, 2024
@Rushaway
Copy link
Contributor

Can't directly move to MySQL 8 ?
MySQL 5.7 EOL was 20 Sep 2023.

@accelerator74 accelerator74 changed the title Update libmaxminddb and MySQL 5.7 Update libmaxminddb and MySQL 8.0 Jul 16, 2024
@accelerator74 accelerator74 changed the title Update libmaxminddb and MySQL 8.0 Update libmaxminddb and MySQL 5.7 Jul 16, 2024
@accelerator74
Copy link
Contributor Author

accelerator74 commented Jul 16, 2024 •
edited
Loading

Can't directly move to MySQL 8 ? MySQL 5.7 EOL was 20 Sep 2023.

This seems to be more problematic. The MySQL 8.0 driver simply won't load, but the build proceeds fine.

psychonic
psychonic approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@psychonic psychonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psychonic psychonic merged commit 932010e into alliedmodders:master Nov 2, 2024
4 checks passed
@accelerator74 accelerator74 deleted the dependencys_upd branch December 13, 2024 09:45
@peace-maker peace-maker mentioned this pull request Dec 15, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychonic psychonic psychonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@accelerator74 @Rushaway @psychonic