Fix reference types not getting unwrapped for overloads.

Bug: issue #970 Test: new test
alliedmodders · Jun 6, 2024 · 2213b8e · 2213b8e
1 parent 79a619c
commit 2213b8e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/compiler/expressions.cpp b/compiler/expressions.cpp
@@ -100,6 +100,11 @@ bool find_userop(SemaContext& sc, int oper, Type* type1, Type* type2, int numpar
     size_t i;
     bool savepri, savealt;
 
+    if (type1->isReference())
+        type1 = type1->inner();
+    if (type2 && type2->isReference())
+        type2 = type2->inner();
+
     /* since user-defined operators on untagged operands are forbidden, we have
      * a quick exit.
      */

diff --git a/tests/regressions/overload-float-ref.out b/tests/regressions/overload-float-ref.out
@@ -0,0 +1,2 @@
+143.750000
+10143.750000
diff --git a/tests/regressions/overload-float-ref.sp b/tests/regressions/overload-float-ref.sp
@@ -0,0 +1,13 @@
+#include <shell>
+
+void test(float& damage) {
+    printf("%f\n", damage);
+    int new_damage = 10000;
+    damage += float(new_damage);
+    printf("%f\n", damage);
+}
+
+public main() {
+    float damage = 143.75;
+    test(damage);
+}