fix + test

allisonport-db · Jan 5, 2024 · 1b23a90 · 1b23a90
1 parent fdcfa62
commit 1b23a90
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/kernel/kernel-api/src/main/java/io/delta/kernel/internal/util/PartitionUtils.java b/kernel/kernel-api/src/main/java/io/delta/kernel/internal/util/PartitionUtils.java
@@ -204,7 +204,9 @@ private static boolean hasNonPartitionColumns(
                     return true;
                 }
             } else {
-                return hasNonPartitionColumns(child.getChildren(), partitionColNames);
+                if(hasNonPartitionColumns(child.getChildren(), partitionColNames)) {
+                    return true;
+                }
             }
         }
         return false;

diff --git a/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/util/PartitionUtilsSuite.scala b/kernel/kernel-api/src/test/scala/io/delta/kernel/internal/util/PartitionUtilsSuite.scala
@@ -128,7 +128,11 @@ class PartitionUtilsSuite extends AnyFunSuite {
       (
         "(column(`part3`) >= sss)",
         "(column(`data1`) = column(`part1`))"
-      )
+      ),
+
+    // predicate only on data column but reverse order of literal and column
+    predicate("=", ofInt(12), col("data1")) ->
+      ("ALWAYS_TRUE()", "(12 = column(`data1`))")
   )
 
   partitionTestCases.foreach {