Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make @Language internal #11

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 17, 2023

  • make @Language internal, to avoid clashes with other libraries (like KxS JSON, which exposes their own implementation of @Language with a @RequiresOptIn guard)
  • Moved @Language to a new directory (while keeping the package the same) - purely because I think the project layout is neater
  • Removed old TODO

Related issues:

@alllex
Copy link
Owner

alllex commented Jun 26, 2023

Visibility change and clean up is good, but I prefer to keep production classes well-structured with respect to the packages.

I moved the class to a directory corresponding to its package.

@aSemy
Copy link
Contributor Author

aSemy commented Jun 26, 2023

Visibility change and clean up is good, but I prefer to keep production classes well-structured with respect to the packages.

I moved the class to a directory corresponding to its package.

I understand, but be aware that it might cause some problems (e.g. on Android) if there are two classes with the same name & dir.

# Conflicts:
#	src/commonMain/kotlin/me/alllex/parsus/token/RegexToken.kt
@alllex alllex merged commit e17c2b8 into alllex:main Jul 26, 2023
3 checks passed
@aSemy aSemy deleted the update_language_annotation branch January 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants