Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates & Enable MinGW #12

Merged
merged 5 commits into from
Jun 24, 2023
Merged

Updates & Enable MinGW #12

merged 5 commits into from
Jun 24, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 17, 2023

Updates, tidyings, and support MinGW (Fix #5)

Summary

  • version bumps
    • Gradle 8.1.1
    • Update Kotlin to 1.8.22
    • AssertK 0.26.1 (which now supports MinGW)
    • Kotlinx Serialization 1.5.1
    • Kotlinx Benchmark 0.4.8
    • Dokka 1.8.20
  • Enable the mingw() target, since AssertK now supports it
  • Move plugin versions to buildSrc/build.gradle.kts. Helps keep the build scripts consistent and cleaner, so all plugin versions are defined in one place
  • disable Configuration Cache. Kotlin Multiplatform will hopefully support it in 1.9.
  • GitHub Workflow updates
    • added PR trigger, so pull requests will be automatically tested
    • re-enable Windows, since it now works, hopefully!
    • cache Kotlin Konan, to improve the build times.
    • Add concurrency cancellation. The builds will now take much longer, because running all tests on all machines is slow (even with caching). Cancelling them when a new build comes it will stop the build queue getting clogged if lots of commits are pushed in quick succession.
    • Removed the --no-cc flag since it's disabled at the project level in gradle.properties

See aSemy#1, which successfully built on all platforms 🎉

- Update Kotlin to 1.8.22
- Move plugin versions to `buildSrc/build.gradle.kts`
- bump AssertK (which now supports MinGW)
- bump Kotlinx Serialization
- bump Kotlinx Benchmark
- bump Dokka
- disable CC
- cache Konan in GH Workflow
@aSemy aSemy marked this pull request as ready for review June 17, 2023 08:30
@alllex
Copy link
Owner

alllex commented Jun 24, 2023

This looks good, thanks!

@alllex alllex merged commit a5bceeb into alllex:main Jun 24, 2023
@aSemy aSemy deleted the fix/mingw branch June 24, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Windows build on CI
2 participants