Skip to content

Commit

Permalink
CR fix
Browse files Browse the repository at this point in the history
  • Loading branch information
alloncm committed Dec 14, 2024
1 parent 74f4103 commit b6ba99f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions core/src/mmu/gb_mmu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,9 @@ impl<'a, D:AudioDevice, G:GfxDevice, J:JoypadProvider> GbMmu<'a, D, G, J>{
if cgb_reg & BIT_7_MASK != 0{
mmu.write(KEY0_REGISTER_ADDRESS, cgb_reg, 0);

// Both the bootroms leaves the PPU turned on, turning it on both modes makes some tests (turtle)
// fail as they seem really sensitive for timing.
// Setting this only for CGB mode (mostly to make games the assumes the PPU is turned on to work).
// Both bootroms leaves the PPU turned on, unfortunately turning it on for both modes makes some tests
// fail as they seem really sensitive to timing.
// Setting this only for CGB mode cgb enabled (mostly to make games the assumes the PPU is turned on to work).
// TODO: Turn on the PPU on both modes while preserving accurate timing.
mmu.write(LCDC_REGISTER_ADDRESS, 0x80, 0);
}
Expand Down

0 comments on commit b6ba99f

Please sign in to comment.