Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/color #97

Merged
merged 3 commits into from
Mar 19, 2023
Merged

Feature/color #97

merged 3 commits into from
Mar 19, 2023

Conversation

alloncm
Copy link
Owner

@alloncm alloncm commented Jul 19, 2022 •
edited
Loading

Add support for Gameboy Color:

  • Add way to force gameboy mode
  • Add new integrations tests for cgb-acid2 MagenTests
  • Manual testing
  • Clean code
  • Update Readme
  • Fix Pokemon Yellow
  • Arrange git

Closes #80

@alloncm alloncm marked this pull request as ready for review December 25, 2022 15:40
alloncm
alloncm commented Dec 25, 2022
View reviewed changes
lib_gb/src/ppu/fifo/background_fetcher.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/fifo/background_fetcher.rs Show resolved Hide resolved
lib_gb/src/ppu/fifo/background_fetcher.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/fifo/background_fetcher.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/fifo/sprite_fetcher.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/gb_ppu.rs Outdated Show resolved Hide resolved
@alloncm
Copy link
Owner Author

alloncm commented Dec 26, 2022

Crash on Tetris DX end game screen

@alloncm
Copy link
Owner Author

alloncm commented Dec 29, 2022

Fix Tetris DX

XD

@alloncm
Copy link
Owner Author

alloncm commented Jan 30, 2023 •
edited
Loading

https://gist.github.com/drhelius/3394856

alloncm
alloncm commented Jan 31, 2023
View reviewed changes
lib_gb/src/machine/mbc_initializer.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/fifo/background_fetcher.rs Outdated Show resolved Hide resolved
lib_gb/src/machine/gameboy.rs Show resolved Hide resolved
gb/src/main.rs Outdated Show resolved Hide resolved
alloncm
alloncm commented Feb 2, 2023
View reviewed changes
lib_gb/tests/vram_dma_controller_tests.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/ppu_register_updater.rs Outdated Show resolved Hide resolved
lib_gb/src/cpu/opcodes/cpu_control_instructions.rs Show resolved Hide resolved
lib_gb/src/mmu/vram_dma_controller.rs Outdated Show resolved Hide resolved
lib_gb/src/mmu/vram_dma_controller.rs Outdated Show resolved Hide resolved
lib_gb/src/mmu/vram_dma_controller.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/gb_ppu.rs Outdated Show resolved Hide resolved
@alloncm alloncm changed the base branch from dev to master February 4, 2023 15:16
@alloncm alloncm force-pushed the feature/color branch 2 times, most recently from b7a50df to 4423d62 Compare February 8, 2023 11:22
@alloncm
Copy link
Owner Author

alloncm commented Feb 8, 2023

Currently Legend of zelda links awakening dx is not working properly in CGB mode, the game boots correctly but wont return gracefully from dialogues and menus.

I wont solve this here but will open an issue for this game

alloncm
alloncm commented Mar 18, 2023
View reviewed changes
lib_gb/src/mmu/gb_mmu.rs Outdated Show resolved Hide resolved
lib_gb/src/ppu/fifo/background_fetcher.rs Outdated Show resolved Hide resolved
@alloncm alloncm mentioned this pull request Mar 19, 2023
Closed
alloncm added 3 commits March 19, 2023 22:22
@alloncm
Add support for Gameboy Color
7613208 
* Implement the new PPU
* Add the expanded rams and the new bootrom
* Support CPU speed switch
* Mode detection on startup
@alloncm
Add new tests for Gameboy Color
533db5f
@alloncm
Update the readme for the Gameboy Color support
3bd5148
@alloncm alloncm merged commit 6a511ff into master Mar 19, 2023
@alloncm alloncm deleted the feature/color branch March 19, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for gameboy color
1 participant
@alloncm