implement From<Response> and From<EthNotification> for PubSubItem (#710)

alloy-rs · May 7, 2024 · 952632b · 952632b
1 parent e4c5756
commit 952632b
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/crates/json-rpc/src/notification.rs b/crates/json-rpc/src/notification.rs
@@ -26,6 +26,18 @@ pub enum PubSubItem {
     Notification(EthNotification),
 }
 
+impl From<Response> for PubSubItem {
+    fn from(response: Response) -> Self {
+        PubSubItem::Response(response)
+    }
+}
+
+impl From<EthNotification> for PubSubItem {
+    fn from(notification: EthNotification) -> Self {
+        PubSubItem::Notification(notification)
+    }
+}
+
 impl<'de> Deserialize<'de> for PubSubItem {
     fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
     where
@@ -94,7 +106,7 @@ impl<'de> Deserialize<'de> for PubSubItem {
                             )
                         })?;
 
-                    Ok(PubSubItem::Response(Response { id, payload }))
+                    Ok(Response { id, payload }.into())
                 } else {
                     // Notifications cannot have an error.
                     if error.is_some() {