-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export inner encoding / decoding functions from Tx*
types
#529
Conversation
82ed4e3
to
842bf91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc nit
@prestwich I think we need to make them pub so that the tx types can be reused externally, for example in a network specific enum that needs to implement rlp
842bf91
to
1956325
Compare
i agree that we need to do this. i would like to open a follow up issue for improving naming, and maybe for feature-gating pub status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we mark these as #[doc(hidden)]
? so that they don't show up in autosuggestions
c5f2436
to
b9f93b8
Compare
…loy-rs#529) * feat: Export inner encoding / decoding functions from `Tx*` types * Add `#[doc(hidden)]` to exposed low-level encoding functions
Overview
Exports a few of the
Tx*
types' inner encoding & decoding functions for use in theop-alloy-consensus
wrapper. Doing so allows us to re-use all of these types in the expanded transaction envelope enum.