feat: Export inner encoding / decoding functions from Tx* types
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
clabby
force-pushed
the
cl/consensus-expose-encoding
branch
2 times, most recently
from
82ed4e3
to
842bf91
Compare
mattsse
requested changes
Apr 14, 2024
There was a problem hiding this comment.
doc nit
@prestwich I think we need to make them pub so that the tx types can be reused externally, for example in a network specific enum that needs to implement rlp
clabby
force-pushed
the
cl/consensus-expose-encoding
branch
from
842bf91
to
1956325
Compare
|
i agree that we need to do this. i would like to open a follow up issue for improving naming, and maybe for feature-gating pub status |
mattsse
requested changes
Apr 15, 2024
clabby
force-pushed
the
cl/consensus-expose-encoding
branch
from
c5f2436
to
b9f93b8
Compare
prestwich
approved these changes
Apr 16, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…loy-rs#529) * feat: Export inner encoding / decoding functions from `Tx*` types * Add `#[doc(hidden)]` to exposed low-level encoding functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Exports a few of the
Tx*types' inner encoding & decoding functions for use in theop-alloy-consensuswrapper. Doing so allows us to re-use all of these types in the expanded transaction envelope enum.