Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alloy-node-bindings #111

Merged
merged 6 commits into from
Jan 14, 2024
Merged

feat: add alloy-node-bindings #111

merged 6 commits into from
Jan 14, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jan 13, 2024

Closes #106

I have not ported Ganache because the Truffle suite has been deprecated: https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat

Removes ethers-core from dev-dependencies.

  • 1st commit: fork from ethers-rs
  • rest: actual changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
some other name suggestions

@@ -0,0 +1,22 @@
[package]
name = "alloy-test-utils"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the name, because these are not only used for testing, for example run some simulations using anvil.

perhaps alloy-nodes, alloy-node-bindings, alloy-node-commands|cmd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// fork switch blocks.
#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "camelCase")]
pub struct Genesis {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these types I wanted to put in its own crate (extracting from reth-primitives)

but for now this is fine

@DaniPopes DaniPopes changed the title feat: add alloy-test-utils feat: add alloy-node-bindings Jan 13, 2024
@DaniPopes DaniPopes merged commit 5ed60f8 into main Jan 14, 2024
17 checks passed
@DaniPopes DaniPopes deleted the dani/test-utils branch January 14, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Port Anvil/Ganache/Geth bindings from ethers-core
2 participants