[Feature] Receipt trait in alloy-consensus #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developeruche
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
@prestwich change status function on rpc receipt type to delegate to Receipt implementation of inner This is not quite possible at the moment; pub enum ReceiptEnvelope<T = Log> ----> This uses Log from and pub struct TransactionReceipt<T = ReceiptEnvelope> ----> This uses Log from |
prestwich
requested changes
Apr 22, 2024
prestwich
approved these changes
Apr 23, 2024
prestwich
reviewed
Apr 23, 2024
| @@ -43,7 +43,7 @@ where | |||
| } | |||
|
|
|||
| impl TxReceipt for Receipt { | |||
There was a problem hiding this comment.
followup work:
- Make this impl generic over
prestwich
reviewed
Apr 23, 2024
| @@ -78,7 +78,7 @@ pub struct ReceiptWithBloom<T = Log> { | |||
| } | |||
|
|
|||
| impl TxReceipt for ReceiptWithBloom { | |||
| fn success(&self) -> bool { | |||
There was a problem hiding this comment.
followup work:
- Make this impl generic over
This was referenced Apr 23, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* introduced Receipt trait * fmt * mod: switch to TxReceipt trait * fmt * impl Receipt for ReceiptEnvelope * mod: removed todo() * resovling comments and CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #466
Solution
PR Checklist