chore(general): add CI workflow for Windows + fix IPC test #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
This was referenced Apr 26, 2024
|
Reopening once I've fixed the run issues in my fork |
zerosnacks
requested review from
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
approved these changes
Apr 30, 2024
zerosnacks
changed the title
prestwich
approved these changes
Apr 30, 2024
onbjerg
approved these changes
Apr 30, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
) * add windows workflow * make sure it runs on the target * export path after modification * update workflow, set tracing for failing geth script * check if geth is in path * comment out other jobs * attempt * use bash shell * works! error on access denied for ipc * make sure Geth tests run serially to avoid ipc access denied * disable ipc by default * remove serial tag * log path * attempt fix by pointing towards Geths spawned IPC * use geth port * windows doesnt allow specific paths to ipc * ipcpath on windows is just the name, not the path * re-enable other jobs tasks * clean up * use custom ipc name to show working * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to cross-platform related issues arising around IPC it makes sense to add a Windows target to the CI workflow to ensure cross-compatibility.
Previously failed to build and run for various reasons, one of them being the path to Geth not being defined correctly for the tests.
Related PR in
core: alloy-rs/core#613Solution
windows-latestas test target, maintaining the existing test matrixshell: bash)--ipcpathrefers to the name of theipcfile, not the actual path as is the case on Unix. Modified the name to show the ability of spawning and referencing with a custom IPC path.alloy-transport-ws.workspacefor ws)serialas tag imported - leftover from Geth debugging but preferable in my opinion.PR Checklist