Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/multicall_example #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xMelkor
Copy link

@0xMelkor 0xMelkor commented Sep 4, 2024

Motivation

A Multicall3 example was missing, and so i added one.

Solution

Added an example under /contracts to fetch 10 UniswapV2 pool addresses with a single RPC call.

PR Checklist

  • Added Documentation
  • Breaking changes

@zerosnacks
Copy link
Member

zerosnacks commented Sep 6, 2024

Hi @0xMelkor thanks for your PR!

There is currently an ongoing conversation about multicall / batched calls in Alloy and what the correct abstraction is. It is likely that the end user won't have to implement it themselves like this example shows.

One relevant PR is: alloy-rs/alloy#1217

Will get back to you once there is more clarity on what direction we want to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants