Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check target architecture as well #15

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jan 27, 2022

If you use svm-rs as a library then some platforms might still show up as supported even though they are not x86_64 (e.g. Linux aarch64, see foundry-rs/foundry#597)

src/platform.rs Outdated Show resolved Hide resolved
@roynalnaruto
Copy link
Contributor

Looks good! Thank you @onbjerg

@roynalnaruto roynalnaruto merged commit f63bca9 into alloy-rs:master Jan 29, 2022
@onbjerg onbjerg deleted the onbjerg/platform-arch branch January 29, 2022 05:29
gakonst added a commit to foundry-rs/foundry that referenced this pull request Jan 31, 2022
charisma98 added a commit to charisma98/foundry that referenced this pull request Mar 4, 2023
0129general added a commit to 0129general/FoundryProject that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants