-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cucumber-jvm] Add attachments to allure reports using cucumber api #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Could you please add a tests?
Sure. I'll work on it. |
allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/AllureCucumber4Jvm.java
Outdated
Show resolved
Hide resolved
Ignore that last commit. Just fixing github user issue. |
@baev Please review and I will add another unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Please add tests for both methods to all adaptor versions
allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/AllureCucumber4Jvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber-jvm/src/main/java/io/qameta/allure/cucumberjvm/AllureCucumberJvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber-jvm/src/main/java/io/qameta/allure/cucumberjvm/AllureCucumberJvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber2-jvm/src/main/java/io/qameta/allure/cucumber2jvm/AllureCucumber2Jvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber2-jvm/src/main/java/io/qameta/allure/cucumber2jvm/AllureCucumber2Jvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber3-jvm/src/main/java/io/qameta/allure/cucumber3jvm/AllureCucumber3Jvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber3-jvm/src/main/java/io/qameta/allure/cucumber3jvm/AllureCucumber3Jvm.java
Outdated
Show resolved
Hide resolved
allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/AllureCucumber4Jvm.java
Outdated
Show resolved
Hide resolved
@baev Please review when you get a chance |
@PavloNikolenko could you please resolve conflicts |
Resolved |
[Sizes | LineLength] io.qameta.allure.cucumberjvm.(AllureCucumberJvm.java:263) |
Do you want me to update that? |
@PavloNikolenko yep, the build should pass before I can merge it |
Can you rebuild that job manually? Looks like something went wrong. |
Why is it failing? |
I found the problem:
is executed for all scenarios and messes up some other unit tests |
Hey @baev. Its all green now. Please take a look when you get a chance. |
@PavloNikolenko thanks! 👍 |
Thank you =) |
Context
This PR allows users of cucumber + allure to add attachments using cucumber api:
scenario.write("Text comment")
scenario.embed(byte[], "image/png")
Cucumber documentation: https://docs.cucumber.io/cucumber/api/#after
Checklist