-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task.add annotation label for link #354
Task.add annotation label for link #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. I so happy that you like our new @LabelAnnotation
feature. But could you please explain in more details what is the use-case of such behaviour for links? I'm ok with adding such functionality but I think we should design it more carefully at this point
allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
Outdated
Show resolved
Hide resolved
allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
Show resolved
Hide resolved
allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java
Outdated
Show resolved
Hide resolved
allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java
Outdated
Show resolved
Hide resolved
@baev Please provide your feedback after comments fix |
allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
Outdated
Show resolved
Hide resolved
allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java
Outdated
Show resolved
Hide resolved
@SergeyPirogov thanks! |
Changes:
This PR corresponds to isssue #353 and add support for Link annotation labling.
Example:
I have test marked by Custom annotation Jira("Jira-456"), so I want to make Allure recognize it as Link and Story:
Before:
After:
Checklist