-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'this' to Step processing (via allure-framework#615) #377
Conversation
@baev Could you please review the pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I don't like the idea of having possibility to use this
in step annotations (even having in mind that allure 1 allow it)
Your request changes signatures of public methods that can be used by 3rd party integrations (many users use this methods in custom aspects)
allure-java-commons/src/main/java/io/qameta/allure/util/AspectUtils.java
Outdated
Show resolved
Hide resolved
allure-java-commons/src/main/java/io/qameta/allure/util/AspectUtils.java
Show resolved
Hide resolved
In my case, I use JUnit 5
@baev Why don't you like to use |
BTW you can use Allure.step API instead of public void execute() throws Throwable {
Allure.step(String.format("Action: %s %s", actionName, actionDescription), () -> {
...
});
} |
allure-java-commons/src/main/java/io/qameta/allure/util/AspectUtils.java
Outdated
Show resolved
Hide resolved
@Denysss thanks! |
fix #615 Add this to Step processing
Checklist