Cucumber 5 Jvm api changes support for allure (fixes #414)

[naveenchandra91]

Allure Cucumber 5 Jvm Support module Added all relevant files for support Cucumber 5 jvm changes

Signed-off-by: NRao nrao@flexera.com

Context

Checklist

• Sign Allure CLA
• Provide unit tests

[claassistantio]

All committers have signed the CLA.

[naveenchandra91]

This commit is to fix #414

[TomBAMU]

TestSourceModel Java Class is justed copied from current cucumber-jvm project, making it volatile when cucumber-jvm project changes again.

[naveenchandra91]

Hi @TomBAMU : Thanks for reviewing. I did try to use the existing TestSourceModel class. However it was returning an internal gherkin package. I reached out to cucumber developer and they replied the following:

We'll be phasing out Gherkin 5 and the internal html formatter at some point in the future after introducing Gherkin 8. The classes you're looking at are an adaptor to make that seemless in the future.
If you need access to the Gherkin AST you can parse the scenarios yourself based on the TestSourceRead event using:
https://search.maven.org/artifact/io.cucumber/gherkin/5.2.0/jar
There is feature request to provide a minimal representation of all pickles that may meet your needs but it depends a bit on how much detail your reporter has.

So I thought to add the logic of parsing gherkin ast from TestSourceRead event directly in the allure-cucumber5-jvm module. I can refactor the code and just add the basic Ast we need(Feature and ScenarioDefinition Ast). Please let me know your thoughts about what do you think would be the best approach here

[TomBAMU]

We'll be phasing out Gherkin 5 and the internal html formatter at some point in the future after introducing Gherkin 8. The classes you're looking at are an adaptor to make that seemless in the future.
If you need access to the Gherkin AST you can parse the scenarios yourself based on the TestSourceRead event using:
https://search.maven.org/artifact/io.cucumber/gherkin/5.2.0/jar
There is feature request to provide a minimal representation of all pickles that may meet your needs but it depends a bit on how much detail your reporter has.

That was a missing information on my side, thanks you! 👍

I can refactor the code and just add the basic Ast we need(Feature and ScenarioDefinition Ast)

That sounds like a resonable approach then.
I liked your restructring of the "runFeature" in the tests, thanks.

[naveenchandra91]

Hi @TomBAMU : I have made the changes to TestSourceModel to keep only basic AST now. @mpkorstanje : I have removed the reference to cucumber-core and cucumber-java package in plugin source(Its still present in the module because its still needed for tests)

[naveenchandra91]

@TomBAMU : Can you please check whether the latest commit is fine?

[naveenchandra91]

Thanks @baev for merging this pull request. When can i expect this to be released?

[baev]

thanks to you for the contribution.

When can i expect this to be released?

this week

[ibrahim-beskat]

Hi @baev,

Has it been released yet? I've been waiting for release to use Allure report for Cucumber 5.5.0.

Thank you.

[baev]

released in 2.13.2