-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add step in allure report for spock framework #429
add step in allure report for spock framework #429
Conversation
commons lang3 collections4
add step
add step for test
check step in test
Шнайдмиллер Алексей Давыдович seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
add params
add param in test
allure-spock/src/main/java/io/qameta/allure/spock/AllureSpock.java
Outdated
Show resolved
Hide resolved
allure-spock/src/main/java/io/qameta/allure/spock/AllureSpock.java
Outdated
Show resolved
Hide resolved
as far as I get from test you provided -- framework blocks are always displayed before all the steps (from allure)? |
The test shows that the allure report prints all the blocks from the spock. Depending on which block of the spock is used, it is printed in the report. |
I mean if you have test like this: given: "given"
step "given step"
when: "when"
step "when step"
then: "then"
step "then step" you'll see the following scenario in the report:
instead of correct nesting
or flat
|
I get it. It was just done not to write a Step. I'll fix that shortcoming tomorrow. |
that is the main concern about this pull request. A wish to find a way to emit events when block start in order to support steps and attachments within blocks. Otherwise we'll immediately get an issue complaining about that. Overall, I see that this one did improve integration for spock users in some way, so I'm down to merge it |
closed via #838 |
Context
Checklist