Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Selenide to 5.11.0 #439

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Bump Selenide to 5.11.0 #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion allure-selenide/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ description = "Allure Selenide Integration"

val agent: Configuration by configurations.creating

val selenideVersion = "5.8.0"
val selenideVersion = "5.11.0"

dependencies {
agent("org.aspectj:aspectjweaver")
Expand Down
6 changes: 3 additions & 3 deletions allure-selenide/src/test/java/io/qameta/allure/selenide/AllureSelenideTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void shouldLogPassedSteps() {
assertThat(selenideStep)
.extracting(StepResult::getName, StepResult::getStatus)
.containsExactly(
"$(dummy source) dummy method()([param1, param2])",
"$(\"dummy source\") dummy method()([param1, param2])",
Status.PASSED
);
}
Expand Down Expand Up @@ -234,7 +234,7 @@ void shouldNotFailIfBrowserIsNotOpened() {
final StepResult selenideStep = extractStepFromResults(results);
assertThat(selenideStep.getStatus()).isEqualTo(Status.BROKEN);
assertThat(selenideStep.getStatusDetails().getMessage()).startsWith("failed to open a browser");
assertThat(selenideStep.getName()).isEqualTo("$(open) https://some.url");
assertThat(selenideStep.getName()).isEqualTo("$(\"open\") https://some.url");
assertThat(selenideStep.getStage()).isEqualTo(Stage.FINISHED);
assertThat(selenideStep.getAttachments()).hasSize(0);
}
Expand Down Expand Up @@ -304,7 +304,7 @@ void shouldLogFailedSteps() {
assertThat(selenideStep)
.extracting(StepResult::getName, StepResult::getStatus)
.containsExactly(
"$(dummy source) dummy method()([param1, param2])",
"$(\"dummy source\") dummy method()([param1, param2])",
Status.BROKEN
);

Expand Down