Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AllureSpock.java for Spock V2 and above #830

Closed
wants to merge 9 commits into from

Conversation

Guter1988
Copy link

@Guter1988 Guter1988 commented Oct 12, 2022

Context

This is a fix for Spock version 2 and above

fixes #510

Checklist

This is a fix for Spock version 2 and above
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the theme:spock Spock Framework related issue label Oct 12, 2022
@Guter1988
Copy link
Author

Hello @baev
Can you please take a look and this pull request? This is a fix for the Spock version above 2

@baev
Copy link
Member

baev commented Oct 17, 2022

@Guter1988 could you please fix the build?

@Guter1988
Copy link
Author

@baev On it

@baev
Copy link
Member

baev commented Oct 19, 2022

@Guter1988 build failure

@Guter1988
Copy link
Author

@baev I saw. Thanks.
Added @SuppressWarnings("unchecked")
Let's see now

@Guter1988
Copy link
Author

@baev Question: I had issue with io.netty:netty-transport-native-kqueue version 78. I have added late dependency 4.1.8410Final at Gradle, and it worked.
My question is - create a new pull request with adding dependency("io.netty:netty-transport-native-kqueue:4.1.84.Final")?

@Guter1988
Copy link
Author

@baev All passed? Need to review now?

@baev
Copy link
Member

baev commented Oct 26, 2022

@Guter1988 I did additional research and since spock2 is based on top of junit-platform we need to introduce separate module for spock2 integration so we can test it properly.

Let me take this task from here, you may expect a new release with support for spock2 later this week

Thanks for all the work anyway

@baev baev closed this Oct 26, 2022
@baev baev mentioned this pull request Oct 26, 2022
2 tasks
@Guter1988
Copy link
Author

Thank you @baev

@Guter1988 Guter1988 deleted the patch-1 branch October 27, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:spock Spock Framework related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for spock 2.0 versions
3 participants