Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interceptors for httpclient5 #935

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add interceptors for httpclient5 #935

merged 3 commits into from
Jul 10, 2023

Conversation

a-simeshin
Copy link
Contributor

@a-simeshin a-simeshin commented Jul 5, 2023 •
edited
Loading

Context

I propose to add a support module for httplclient5, since the allure-httpclient module cannot be used with httpclient5 due to large changes in package names, httpclient5's API and interceptors.

Checklist

baev
baev approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@baev baev added the type:new feature Change that add something new for end users label Jul 10, 2023
@baev baev merged commit 466aa0b into allure-framework:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:build type:new feature Change that add something new for end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-simeshin @baev