Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allure metadata in playwright test and group annotations v2.0 #1233

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Jan 28, 2025

Context

The PR is a just continuation of #1220.

After a short discussion with @baev, we decided to divide Playwright annotations on 3 different types:

  • well-known annotations such as fixme, issue, skip etc., which should be processed in a certain way
  • Allure Metadata annotations which starts with @allure. or allure. prefix (e.g. @allure.id or allure.label.epic) which appears in the labels
  • rest annotations which should be presented as empty steps with name matching annotation name: annotation description pattern

Checklist

@github-actions github-actions bot added theme:api Javascript API related issue theme:playwright labels Jan 28, 2025
@epszaw epszaw added the type:improvement Improvement or request label Jan 28, 2025
@epszaw epszaw requested a review from baev January 28, 2025 17:19
packages/allure-playwright/src/index.ts Outdated Show resolved Hide resolved
packages/allure-playwright/src/index.ts Outdated Show resolved Hide resolved
packages/allure-playwright/src/index.ts Show resolved Hide resolved
packages/allure-playwright/vitest.config.ts Outdated Show resolved Hide resolved
@epszaw epszaw requested a review from baev January 28, 2025 17:30
@baev baev merged commit fa62742 into main Jan 28, 2025
12 checks passed
@baev baev deleted the better-pw-annotations-support branch January 28, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue theme:playwright type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants