Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host and thread labels for cucumberjs (fixes #454) #459

Merged
merged 10 commits into from
Aug 4, 2022
Merged

Add host and thread labels for cucumberjs (fixes #454) #459

merged 10 commits into from
Aug 4, 2022

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Jun 27, 2022 •
edited
Loading

Context

fixes #454

Checklist

  • [Sign Allure CLA][cla]
  • Provide unit tests

@epszaw epszaw added type:improvement Improvement or request theme:cucumberjs CucumberJS related issue labels Jun 27, 2022
@epszaw epszaw requested a review from baev June 27, 2022 13:05
@epszaw epszaw changed the title Add host label for cucumberjs Add host and thread labels for cucumberjs Jun 27, 2022
@epszaw epszaw changed the title Add host and thread labels for cucumberjs Add host and thread labels for cucumberjs (fixes #454) Jun 27, 2022
@epszaw epszaw force-pushed the cucumberjs-host-n-tread-labels branch from 403f674 to f07896e Compare June 27, 2022 14:33
baev
baev requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a possibility to set host/thread via env variables. Don't forget to add readme section about that as well

packages/allure-cucumberjs/src/CucumberJSAllureReporter.ts Outdated Show resolved Hide resolved
packages/allure-cucumberjs/src/CucumberJSAllureReporter.ts Outdated Show resolved Hide resolved
@epszaw epszaw requested a review from baev August 4, 2022 13:47
@github-actions github-actions bot added theme:api Javascript API related issue theme:build labels Aug 4, 2022
@epszaw epszaw force-pushed the cucumberjs-host-n-tread-labels branch from 373f2d5 to d6bcff8 Compare August 4, 2022 14:16
@github-actions github-actions bot removed theme:api Javascript API related issue theme:build labels Aug 4, 2022
@baev baev merged commit 179b64c into master Aug 4, 2022
@baev baev deleted the cucumberjs-host-n-tread-labels branch August 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:cucumberjs CucumberJS related issue type:improvement Improvement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CucumberJS: Add host & thread labels
2 participants
@epszaw @baev