Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cucumber): add fullName and testCaseId props #530

Merged
merged 5 commits into from
Nov 23, 2022
Merged

feat(cucumber): add fullName and testCaseId props #530

merged 5 commits into from
Nov 23, 2022

Conversation

vovsemenv
Copy link
Collaborator

fixes #518

Full Name allow result to have historical data and create testcases in testops

@vovsemenv vovsemenv added type:improvement Improvement or request theme:cucumberjs CucumberJS related issue labels Nov 23, 2022
@vovsemenv vovsemenv requested a review from epszaw November 23, 2022 10:32
@github-actions github-actions bot added the theme:api Javascript API related issue label Nov 23, 2022
@vovsemenv vovsemenv requested a review from baev November 23, 2022 11:04
epszaw
epszaw approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The code looks nice. Guess nothing gonna be wrong.

@baev baev changed the title Add fullname to cucumber tests Add fullName and testCaseId to cucumber tests Nov 23, 2022
@baev baev changed the title Add fullName and testCaseId to cucumber tests feat(cucumber): add fullName and testCaseId props Nov 23, 2022
@baev baev merged commit 6d35e98 into master Nov 23, 2022
@baev baev deleted the cucumber-fullname branch November 23, 2022 11:15
@baev
Copy link
Member

baev commented Nov 23, 2022

@vovsemenv thanks!

@vovsemenv vovsemenv mentioned this pull request Nov 23, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

@epszaw epszaw epszaw approved these changes

Assignees
No one assigned
Labels
theme:api Javascript API related issue theme:cucumberjs CucumberJS related issue type:improvement Improvement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test cases I upload with test results appear in launches/tree but not in test cases
3 participants
@vovsemenv @baev @epszaw