Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cucumberjs): attach a datable to the step #548

Merged

Conversation

egerix
Copy link
Contributor

@egerix egerix commented Dec 15, 2022

Context

split pr #546
When I switched to allure in cucumber v8, I encountered a number of problems that were not repeated in cucumber v6:

  • Attachments with the datatable are placed at the end of the test, not under the expected step. This is very unattractive if the test has several datatables. Previously, in Cucumber 6, they were placed under each step.

some pictures with changes:
problem before fix:
image

problem after fix:
image

Checklist

@github-actions github-actions bot added the theme:cucumberjs CucumberJS related issue label Dec 15, 2022
Copy link
Collaborator

@vovsemenv vovsemenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, please fix formatting

@vovsemenv vovsemenv added the type:improvement Improvement or request label Dec 15, 2022
@baev baev merged commit 93313a7 into allure-framework:master Dec 15, 2022
@baev
Copy link
Member

baev commented Dec 15, 2022

@egerix thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:cucumberjs CucumberJS related issue type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants