Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default status detector should return broken status #11

Closed
remorhaz opened this issue Oct 12, 2021 · 0 comments · Fixed by #14
Closed

Default status detector should return broken status #11

remorhaz opened this issue Oct 12, 2021 · 0 comments · Fixed by #14

Comments

@remorhaz
Copy link
Contributor

Here in commons module we have no information on how to detect failed assertion from other errors. So, default behavior should be marking any test as broken. Extensions should define their own status detectors, using default one only as fallback.
@remorhaz remorhaz changed the title [v2] Default status detector should return broken status Default status detector should return broken status Oct 14, 2021
@remorhaz remorhaz mentioned this issue Oct 15, 2021
Merged
@baev baev closed this as completed in #14 Oct 15, 2021
baev pushed a commit that referenced this issue Oct 15, 2021
@remorhaz
rft labels and statuses api (fixes #11, fixes #12, fixes #13, via #14)
78abc21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Labels and status detection refactorings
1 participant
@remorhaz