WIP: Use 'sharp' for thumbnail generation #577
+261
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around an Electron crash that occurs when creating thumbnails for very large images when using Canvas for resizing. * Add 'sharp' library * Bump electron minor version to deal with lovell/sharp#3384 fixup
|
Awesome, thanks for taking the time to dive into this! That setup from the Companion repo seems to be cross-platform, I'll try to find some time soon to see if it's compatible on my Linux machine too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to fix #448 but also speeds thumbnail generation up quite a bit - I know this was tried before and ran into build issues.
I looked for instances of
sharpandelectron-buildshowing up in the samepackage.jsonto crib a workaround from - specifically I lifted from https://github.com/bitfocus/companion/blob/master/package.json - I'm not particularly familiar with node or Electron, and I suspect this doesn't yet fully work on Linux and Mac, but I'm likely to run this local fork indefinitely if no other fix for the crash issue lands so I figured I'd post the progress I'd made on it.