Hack: ignore filename for path equality #614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to see/exclude pictures from a specific directory. This feels more natural, since the file path uses a directory as a filter by default. Could be otherwise implemented by upping schema version and saving another column for directory path in db, but it's more duplicate data, and would prevent going back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of a hack in order to be able to see/exclude pictures from a specific directory.
It feels more natural, since the file path uses a directory as a filter by default.
Could be otherwise implemented by upping schema version and saving another column for directory path in db, but it's more duplicate data, and would prevent going back.
The rationale is that the file path filter is used to filter directories, a common user may not even imagine it's the full path and would be confused that they can't filter the current directory by simply choosing "Equals".
Potentially a solution to #398
There could be an option to choose if to default to "Starts With", or "Equals" when opening a folder.