Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ecom 2204 php client create new endpoint add order status by payment route #155

Merged

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

https://linear.app/almapay/issue/ECOM-2204/[-php-client]-create-new-endpoint

Code changes

New endpoint in payment for order status

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Francois-Gomis Francois-Gomis requested review from a team as code owners December 6, 2024 09:53
@Francois-Gomis Francois-Gomis changed the base branch from main to develop December 6, 2024 09:53
@Francois-Gomis Francois-Gomis removed the request for review from a team December 6, 2024 09:54
src/Endpoints/Payments.php Outdated Show resolved Hide resolved
src/Endpoints/Payments.php Show resolved Hide resolved
src/Lib/BoolUtils.php Outdated Show resolved Hide resolved
src/Lib/StringUtils.php Outdated Show resolved Hide resolved
src/Endpoints/Payments.php Outdated Show resolved Hide resolved
src/Endpoints/Payments.php Show resolved Hide resolved
tests/Unit/Endpoints/PaymentsTest.php Show resolved Hide resolved
tests/Unit/Endpoints/PaymentsTest.php Show resolved Hide resolved
tests/Unit/Endpoints/PaymentsTest.php Outdated Show resolved Hide resolved
tests/Unit/Endpoints/PaymentsTest.php Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 6, 2024

@Francois-Gomis Francois-Gomis requested a review from webaaz December 6, 2024 14:00
@Francois-Gomis Francois-Gomis merged commit de30e78 into develop Dec 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants