Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates of printing to improve UX, Updating Traefik #40

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Minor updates of printing to improve UX, Updating Traefik #40

wants to merge 5 commits into from

Conversation

hydroid7
Copy link
Contributor

Changes:

  • Updating Traefik to v2.10.0
  • Printing the push filesize before deploy to avoid pushing of large images
  • Adds emojis to the client output makes it distinguishable from server output.

almarklein
almarklein reviewed Oct 24, 2023
View reviewed changes
Copy link
Owner

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice improvements! Just two minor comments.

mypaas/client/_keys.py
pp = ""

try:
return PrivateKey.from_str(text, pp)
except Exception as err:
raise RuntimeError(f"Could not load key from {filename}: {str(err)}")
raise RuntimeError(f":x: Could not load key from {filename}: {str(err)}")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? This does not pass by rich, does it?

mypaas/client/_push.py Outdated Show resolved Hide resolved
@almarklein
Copy link
Owner

almarklein commented Apr 24, 2024 •
edited
Loading

Instead of adding rich as a dependency, just to print a few emojis, let's just add in the emojis directly (its just unicode, you can copy-paste them in the messages in the source).

>>> import rich
>>> rich.print(":x::information_source::heavy_check_mark:")
❌ℹ✔

@hydroid7
Copy link
Contributor Author

Indeed, that's a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almarklein almarklein almarklein left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hydroid7 @almarklein