This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DataSet.get([undefined]) returns [null], should return [] instead #2839
Comments
macleodbroad-wf
added a commit
to macleodbroad-wf/vis
that referenced
this issue
Jul 27, 2017
…e missing ids are handled.
Ah, right. I see what you mean. When id's are not found I'll spend some time on this. The fix for this particular issue is easy of course, but I also want to add unit tests as well to catch this and as many similar edge cases as possible. |
macleodbroad-wf
pushed a commit
to macleodbroad-wf/vis
that referenced
this issue
Jul 29, 2017
…put/output of get() when passed multiple ids.
yotamberk
pushed a commit
that referenced
this issue
Aug 8, 2017
…put of get() when passed multiple ids. (#3315)
The documentation issue has been resolved by adjusting it to fit the current working. |
primozs
pushed a commit
to primozs/vis
that referenced
this issue
Jan 3, 2019
…put/output of get() when passed multiple ids. (almende#3315)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The documentations says:
But that's not the case, reading the code at https://github.com/almende/vis/blob/master/lib/DataSet.js#L373 it pushes item to the array no matter what is found.
The text was updated successfully, but these errors were encountered: