This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Documentation issue for joinCondition + clusterByConnection #3316
Comments
|
Confirmed. Well spotted. We'll put someone on this to fix it. |
macleodbroad-wf
pushed a commit
to macleodbroad-wf/vis
that referenced
this issue
Jul 30, 2017
…or edge-case of how clusterByConnection uses the joinCondition callback
yotamberk
pushed a commit
that referenced
this issue
Aug 8, 2017
#3319) * Fixes Issue #3316 - Updates network documentation to account for edge-case of how clusterByConnection uses the joinCondition callback * Move the text 'clusterByConnection will pass ... callback.' to under 'Optional for all but the cluster method'. Make it clear that clusterByConnection is the only one that uses the second call. Instead of bold, make it a distinct paragraph.
primozs
pushed a commit
to primozs/vis
that referenced
this issue
Jan 3, 2019
…or edge… (almende#3319) * Fixes Issue almende#3316 - Updates network documentation to account for edge-case of how clusterByConnection uses the joinCondition callback * Move the text 'clusterByConnection will pass ... callback.' to under 'Optional for all but the cluster method'. Make it clear that clusterByConnection is the only one that uses the second call. Instead of bold, make it a distinct paragraph.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When clustering network nodes, the various cluster functions all take an options object which includes a
joinConditioncallback. This is documented (docs/network) as receiving a singlenodeOptionsparameter. That's true for most of the cluster functions, but not forclusterByConnectionwhere it receives two - one for the parent node and one for the actual candidate (child) node.The text was updated successfully, but these errors were encountered: