This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Network: options passed into API calls by user should not be changed. #3548
Comments
wimrijnders
added a commit
to wimrijnders/vis
that referenced
this issue
Oct 13, 2017
Fixes almende#3543. None of the options passed in any of the API calls should change the options. This has been registered with issue almende#3548.
yotamberk
pushed a commit
that referenced
this issue
Oct 13, 2017
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this issue
Jun 9, 2019
Fixes almende#3543. None of the options passed in any of the API calls should change the options. This has been registered with issue almende#3548.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This issue is prompted by #3543.
Related to #1660.
The API calls should all abide to the following rule:
All passed in user options should not be modified.
Not doing this can lead to confusion due to unexpected behavior, as in #3543.
Action: Scan all API calls for changing of option parameters, make internal copies when this is the case.
The text was updated successfully, but these errors were encountered: