Toggle Group Visibility #2303
Toggle Group Visibility #2303
Conversation
There was a problem hiding this comment.
Nice! Thanks for the PR!
The thing is, I don't see how this feature is needed. A user can simply add to their group an attribute of visible:false dynamically and simply set the groups with the filtered groups (e.g. using groups.filter or with the dataset filter). Not huge benefit to this feature but I'm willing to approve it. Thanks for the contribution!
|
|
||
|
|
||
| // loop through groups and convert content strings into elements with hide buttons. | ||
| groups.forEach(function(group){ |
There was a problem hiding this comment.
You're better off using the options.groupTemplate to achieve this. This seems kind of hacky and unclear...
There was a problem hiding this comment.
I hadn't considered that. I'll give that a shot.
|
I tried your idea with the dataset.filter and it works just as well as the PR. It is probably a better solution since it likely has less overhead for hidden groups. What i'll do then is break up the PR to remove the changes to the library and instead i'll modify the example to use the dataset.filter. Then #257 can reference the updated example and be closed. |
|
So I'll close this PR and when you're ready with a new one, please resubmit =) |
This is an implementation of the feature requested in #257. This only toggles group visibility not subgroup visibility. This also includes and update to the documentation and an example page to highlight the new feature.