This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Graph3d: move Filter into DataGroup #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Filter` instance within `Graph3d` is intimately connected to the graph data, contained in a `DataGroup` instance. As such, it needs to be placed within `DataGroup`. A consequence of this is that, in the final case of multiple graphs, each graph can be animation separately. I regard this as an advantage, even though it will means more initialization for the graphs (you have to initialize each separately for an animation. An effort has been made to decouple `Graph3d` and `Filter` as much as possible. There are still some relationships present, but it's more bother than it's worth to dissolve these. In addition to moving the `Filter` instance, the following has been done: - Added variable `style` to `DataGroup` - Moved certain data-specific methods from `Graph3d` to `DataGroup` - cleaned up some code and commenting These changes have been tested with the following examples: - `graph3d/10_styling` - `graph3d/03_filter_data` - `graph3d/04_animation`
yotamberk
approved these changes
Jul 21, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Graph3D: move Filter into DataGroup The `Filter` instance within `Graph3d` is intimately connected to the graph data, contained in a `DataGroup` instance. As such, it needs to be placed within `DataGroup`. A consequence of this is that, in the final case of multiple graphs, each graph can be animation separately. I regard this as an advantage, even though it will means more initialization for the graphs (you have to initialize each separately for an animation. An effort has been made to decouple `Graph3d` and `Filter` as much as possible. There are still some relationships present, but it's more bother than it's worth to dissolve these. In addition to moving the `Filter` instance, the following has been done: - Added variable `style` to `DataGroup` - Moved certain data-specific methods from `Graph3d` to `DataGroup` - cleaned up some code and commenting These changes have been tested with the following examples: - `graph3d/10_styling` - `graph3d/03_filter_data` - `graph3d/04_animation` * Add changes to filter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next iteration for the implementation of multi-graphs in
Graph3d.The
Filterinstance withinGraph3dis intimately connected to the graph data,contained in a
DataGroupinstance. As such, it needs to be placed withinDataGroup.A consequence of this is that, in the final case of multiple graphs, each graph can be
animated separately. I regard this as an advantage, even though it will means more
initialization for the graphs (you have to initialize each separately for an animation).
An effort has been made to decouple
Graph3dandFilteras much as possible. Thereare still some relationships present, but it's more bother than it's worth to dissolve these.
In addition to moving the
Filterinstance, the following has been done:styletoDataGroupGraph3dtoDataGroupThese changes have been tested with the following examples:
graph3d/10_stylinggraph3d/03_filter_datagraph3d/04_animation