This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix missing reference to Graph3D instance in DataGroup #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for almende#3251 A reference was missed in DataGroup.reload() during refactoring. Rather than fix this method, it has been removed and the logic moved to `Graph3d`. This makes for somewhat cleaner code.
bradh
previously approved these changes
Jul 14, 2017
lib/graph3d/Graph3d.js
Outdated
| @@ -702,7 +702,7 @@ Graph3d.prototype.setOptions = function (options) { | |||
| this._setSize(this.width, this.height); | |||
|
|
|||
| // re-load the data | |||
| this.dataGroup.reload(); | |||
| this.setData(this.dataGroup.getDataTable()); | |||
There was a problem hiding this comment.
Space of course. Spaces rule!
wimrijnders
added a commit
to wimrijnders/vis
that referenced
this pull request
Jul 15, 2017
This adds a unit test for PR almende#3255 which fixes almende#3251. The unit test will fail without the PR merged. **NOTE:** This also adds module `canvas`, required for the unit test. This module proved to be quite fickly to install properly. During reviewing, please pay special attention to the proper installation of this modul. I.e. do following to test: ``` > npm install # If no errors, continue > npm test /tests/Graph3D.test.js # Run unit test isolated ```
yotamberk
approved these changes
Jul 16, 2017
yotamberk
pushed a commit
that referenced
this pull request
Jul 20, 2017
* Add unit tests for Graph3D issue This adds a unit test for PR #3255 which fixes #3251. The unit test will fail without the PR merged. **NOTE:** This also adds module `canvas`, required for the unit test. This module proved to be quite fickly to install properly. During reviewing, please pay special attention to the proper installation of this modul. I.e. do following to test: ``` > npm install # If no errors, continue > npm test /tests/Graph3D.test.js # Run unit test isolated ``` * Fix for travis-cl * Add giflib to travis test definition * Add libgif to travis test definition - take 2 * Proper setup and teardown for jsdom-global * Minor fixes and cleanup
agnesnanxin
pushed a commit
to agnesnanxin/vis
that referenced
this pull request
Aug 30, 2017
* Fix missing reference to Graph3D instance in DataGroup Fix for almende#3251 A reference was missed in DataGroup.reload() during refactoring. Rather than fix this method, it has been removed and the logic moved to `Graph3d`. This makes for somewhat cleaner code. * Fixes due to review
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Fix missing reference to Graph3D instance in DataGroup Fix for almende#3251 A reference was missed in DataGroup.reload() during refactoring. Rather than fix this method, it has been removed and the logic moved to `Graph3d`. This makes for somewhat cleaner code. * Fixes due to review
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Add unit tests for Graph3D issue This adds a unit test for PR almende#3255 which fixes almende#3251. The unit test will fail without the PR merged. **NOTE:** This also adds module `canvas`, required for the unit test. This module proved to be quite fickly to install properly. During reviewing, please pay special attention to the proper installation of this modul. I.e. do following to test: ``` > npm install # If no errors, continue > npm test /tests/Graph3D.test.js # Run unit test isolated ``` * Fix for travis-cl * Add giflib to travis test definition * Add libgif to travis test definition - take 2 * Proper setup and teardown for jsdom-global * Minor fixes and cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3251.
A reference was missed in
DataGroup.reload()during refactoring.Rather than fix this method, it has been removed and the logic moved to
Graph3d.This makes for somewhat cleaner code.