This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Upgrade packages and tools for Travis unit testing #3262
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
957e483
Add C++11 and canvas module for travis tests
wimrijnders 018fd27
Added libgif, updated version gulp-clean-css
wimrijnders 64b6632
Update version webpack
wimrijnders 3150be9
Force versions minimatch, graceful-fs; fixes for upgraded webpack
wimrijnders ff977eb
Force version minimatch through travis.yml
wimrijnders 6efb2b7
Fix comma's in json
wimrijnders 1ddfb28
Add extraneous modules to package.json; final attempt at forcing vers…
wimrijnders 2799b20
Final changes module versions
wimrijnders 1e2e6cb
Fix due to linting
wimrijnders 2f493f1
Fix typo in package.json
wimrijnders 9927c75
Upgrade eslint
wimrijnders File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,5 +22,6 @@ | |
"no-redeclare": 0, | ||
"no-unreachable": 1, | ||
"no-unused-vars": 0, | ||
"no-useless-escape": 0, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wimrijnders What do we need this for? This module requires Cairo wich is an unacceptable external dependency. Since this I can not install vis anymore on linux 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
canvas
is used to run unit tests onNetwork
. Why iscairo
an unacceptable external dependency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cairo can not be installed via npm and therefor adds a OS-specific dependency. How should the user (like me) know that he has to install g++ and libgif-dev?
npm install
now just fails. I personally think this is not acceptable!We should not have dependencies other that
npm
(and maybegit
) as far as I'm concerned.The least thing would be to document this in the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue for that: #3515 Lets discuss over there, what the best way is to solve this.