This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix manipulation examples for Network #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for almende#2856 - Toolbar gets reshown when cancelling edit node dialog - No shadow displayed upon save in edit node dialog The latter is actually a more general problem. Function `mergeOptions` in `util.js` made an assumption as to the correct value of field `enabled`. It now takes the value from `globalOptions`, if present.
yotamberk
approved these changes
Jul 20, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
Fix for almende#2856 - Toolbar gets reshown when cancelling edit node dialog - No shadow displayed upon save in edit node dialog The latter is actually a more general problem. Function `mergeOptions` in `util.js` made an assumption as to the correct value of field `enabled`. It now takes the value from `globalOptions`, if present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a small fix, should be easily reviewable.
Fix for #2856
The latter is actually a more general problem. Function
mergeOptions()inutil.jsmade an assumption as to the correct value of field
enabled. It now takes the valuefrom
globalOptions, if present.