Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Makes Network, DataSet and DataView eslint compliant #3304

Merged
merged 3 commits into from
Aug 1, 2017

Conversation

macleodbroad-wf
Copy link
Contributor

@macleodbroad-wf macleodbroad-wf commented Jul 28, 2017

R: @wimrijnders @mojoaxel

Rather than follow a dogmatic approach, I did break some eslint rules.

I believe that even though some variables are unused, they are well placed to communicate the intent and expected usage of the function.

Unused variables in private functions, who were never called internally with those arguments were removed.
lint rule was disabled for public functions, and in private functions which were called internally with those unused arguments
@wimrijnders
Copy link
Contributor

Rather than follow a dogmatic approach, I did break some eslint rules....

I see it, unused parameters for certain methods. Tagging them with eslint-disable is a valid solution here.

@wimrijnders
Copy link
Contributor

Your linting fixes are all good; however, when I run linting, I also get errors on the following files:

lib/network/modules/components/nodes/shapes/Circle.js
lib/network/modules/components/nodes/shapes/CircularImage.js
lib/network/modules/components/nodes/shapes/Dot.js
lib/network/modules/components/nodes/util/CircleImageBase.js

Did you skip these intentionally? Or didn't they show up during linting?

wimrijnders
wimrijnders previously approved these changes Jul 28, 2017
Copy link
Contributor

@wimrijnders wimrijnders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Copy link
Contributor

@wimrijnders wimrijnders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also for the newly added files

@wimrijnders wimrijnders changed the title Makes network eslint compliant Makes Network, DataSet and DataView eslint compliant Jul 29, 2017
@yotamberk yotamberk merged commit 0df59c8 into almende:develop Aug 1, 2017
primozs pushed a commit to primozs/vis that referenced this pull request Jan 3, 2019
* Makes network eslint compliant
Unused variables in private functions, who were never called internally with those arguments were removed.
lint rule was disabled for public functions, and in private functions which were called internally with those unused arguments

* Disables linting for unused args passed into DataSet and DataView
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants